Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscoped constructors in a vector #9630

Merged

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Apr 4, 2024

Pull Request Description

Tests for autoscoped constructors in a vector and allowing comments in multiline expression block.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
    style guides.blob/develop/docs/style-guide/rust.md) style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 4, 2024
@JaroslavTulach JaroslavTulach self-assigned this Apr 4, 2024
@JaroslavTulach JaroslavTulach requested a review from farmaazon April 4, 2024 10:19
result 00e33517-6d19-4f5a-84c5-126f59a93b67 result: (Count '') type: Aggregate_Column

pair.first.column_names . should_equal pair.second.column_names
pair.first.column_names.map n->
Copy link
Member Author

@JaroslavTulach JaroslavTulach Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test verifies that both Tables contain the same elements - e.g. resolution of autoscoped constructors works fine in runtime thanks to 5f9aa25 change.


interesting_uuids = Vector.new_builder
# line 9: (..Count)
. append "4cf46843-236f-4551-a9cc-30dd7552bb5f" # 287, 1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in the

resulted in NullPointerException and required 9cc208d fix.

Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one slight change pls

@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/Table_Aggregate_Auto_Constructor_9614 branch from 2c4b2c3 to 5f9aa25 Compare April 4, 2024 12:22
@JaroslavTulach JaroslavTulach merged commit d9c7bf4 into develop Apr 4, 2024
36 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/Table_Aggregate_Auto_Constructor_9614 branch April 4, 2024 15:13
@enso-bot
Copy link

enso-bot bot commented Apr 5, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-04):

Progress: - PR with the instrumentation: #9630

Next Day: Take a look at Table.join

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants