-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoscoped constructors in a vector #9630
Autoscoped constructors in a vector #9630
Conversation
result 00e33517-6d19-4f5a-84c5-126f59a93b67 result: (Count '') type: Aggregate_Column | ||
|
||
pair.first.column_names . should_equal pair.second.column_names | ||
pair.first.column_names.map n-> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new test verifies that both Table
s contain the same elements - e.g. resolution of autoscoped constructors works fine in runtime thanks to 5f9aa25 change.
|
||
interesting_uuids = Vector.new_builder | ||
# line 9: (..Count) | ||
. append "4cf46843-236f-4551-a9cc-30dd7552bb5f" # 287, 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments in the
resulted in NullPointerException
and required 9cc208d fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one slight change pls
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Aggregate_Column_Helper.enso
Outdated
Show resolved
Hide resolved
2c4b2c3
to
5f9aa25
Compare
Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-04): Progress: - PR with the instrumentation: #9630
Next Day: Take a look at |
Pull Request Description
Tests for autoscoped constructors in a vector and allowing comments in multiline expression block.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,
style guides.blob/develop/docs/style-guide/rust.md) style guide.